perf: optimize CLIENT SETINFO calls in SearchIndex.from_existing() (#358) #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduces duplicate CLIENT SETINFO calls when creating an index from an existing Redis index by tracking client validation state. When a client is validated in from_existing(), the _client_validated flag is set to prevent redundant validation in the property getter. Addresses part of #358 by minimizing Redis command overhead during index initialization.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes Redis client initialization by eliminating duplicate CLIENT SETINFO calls when creating search indexes from existing Redis indexes. The optimization tracks client validation state to prevent redundant validation operations.
- Introduced
_client_validatedparameter to track validation state across index initialization - Modified both sync and async
from_existing()methods to set validation flag after client validation - Updated constructors to accept and use the validation state flag
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces duplicate CLIENT SETINFO calls when creating an index from an existing Redis index by tracking client validation state.
When a client is validated in from_existing(), the _client_validated flag is set to prevent redundant validation in the property getter.
Addresses part of #358 by minimizing Redis command overhead during index initialization.